[developers] Bug fix not merged with LKB code

[Bernd Kiefer]

Hi,

i just re-identified a bug in LKB that i already fixed two years
ago. This time, it involved about three persons work for two days to
pin it down.  We obviously used a frozen LKB most of the time,
otherwise this would have reappeared earlier.

Maybe somebody can verify that this change is OK in the LKB environment
too and can propagate it into the CVS. Thanks to anyone who'll do it.

diff -c -r1.72 mrsoutput.lisp
*** mrsoutput.lisp      8 Feb 2006 14:08:13 -0000       1.72
--- mrsoutput.lisp      24 Mar 2006 12:00:54 -0000
***************
*** 255,261 ****
        (intern (apply #'concatenate 'string
                       (string (car flist))
                       (mapcan #'(lambda (f) (list "." (string f))) (cdr flist)))
!               :lkb)
      (car flist)))


--- 255,261 ----
        (intern (apply #'concatenate 'string
                       (string (car flist))
                       (mapcan #'(lambda (f) (list "." (string f))) (cdr flist)))
!               :mrs)
      (car flist)))

Best,
        Bernd

This is the orginial mail:

> the problem with the rmrs was to fix easily, once i found out that it
> was a package problem. The 'feat' values containing a dot, such as
> png.pn in the first argument of 'simple-var-extra-check' were in the 
> LKB package, while the symbols in the *var-extra-mrs-compiled-table*
> were in the MRS table.
> 
> I fixed the problem by changing the function make-mrs-feature:
> 
> *** mrsoutput.lisp      Tue Apr 27 11:25:52 2004
> --- /project/cl/deepthought/lkb/src/mrs/mrsoutput.lisp  Mon Apr 26 09:23:44 2004
> ***************
> *** 228,232 ****
>   (defun make-mrs-feature (flist)
>     (if (cdr flist)
> !       (intern (format nil "~A~{.~A~}" (car flist) (cdr flist)) :mrs)
>       (car flist)))
>   
> --- 228,232 ----
>   (defun make-mrs-feature (flist)
>     (if (cdr flist)
> !       (intern (format nil "~A~{.~A~}" (car flist) (cdr flist)) :lkb)
>       (car flist)))
> 
> I don't know if this produces a problem in LKB. Maybe you could check
> that. 
> 
> Thanks for your hints!
> 
> Greetings,
>                 Bernd
 
-- 
**********************************************************************
Bernd Kiefer                                            Am Blauberg 16
kiefer at dfki.de                                      66119 Saarbruecken
+49-681/302-5301 (office)                      +49-681/3904507  (home)
**********************************************************************