[developers] two PET fixes checked into svn

[Eric Nichols]

Greetings,

I'm getting similar errors here, too. g++ seems to be getting fussy about
converting the return value of find_last_of() to an iterator. I wrote a
patch to work around the problem by using ints instead of iterators. To
confirm, the changes to xml-tokenizer.cpp are to strip all newlines from the
input, right?

Eric

g++ -DDYNAMIC_SYMBOLS -DDAG_TOMABECHI  -I. -I. -I..  -I../common
-I/usr/include -I/usr/lib/ecl/h -I/usr/include   -g -Wall -O2
-DDYNAMIC_SYMBOLS -DDAG_TOMABECHI   -c -o xml-tokenizer.o xml-tokenizer.cpp
xml-tokenizer.cpp: In member function â:
xml-tokenizer.cpp:30: error: conversion from â to non-scalar type â
requested
xml-tokenizer.cpp:34: error: no match for â in â
/usr/lib/gcc/i486-linux-gnu/4.1.2/../../../../include/c++/4.1.2/bits/stl_iterator.h:634:
note: candidates are: __gnu_cxx::__normal_iterator<char*,
std::basic_string<char, std::char_traits<char>, std::allocator<char> > >&
__gnu_cxx::__normal_iterator<char*, std::basic_string<char,
std::char_traits<char>, std::allocator<char> > >::operator=(const
__gnu_cxx::__normal_iterator<char*, std::basic_string<char,
std::char_traits<char>, std::allocator<char> > >&)
make[3]: *** [xml-tokenizer.o] Error 1
make[3]: Leaving directory `/home/eric-n/tmp/pet-0.99.13-3-20070215
/build-tree/pet-0.99.13/cheap'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/eric-n/tmp/pet-0.99.13-3-20070215
/build-tree/pet-0.99.13'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/home/eric-n/tmp/pet-0.99.13-3-20070215
/build-tree/pet-0.99.13'
make: *** [debian/stamp-makefile-build] Error 2

On 2/15/07, Rebecca Dridan <bec.dridan at gmail.com> wrote:
>
> This last fix won't compile for me:
>
> xml-tokenizer.cpp: In member function 'virtual void
> tXMLTokenizer::tokenize(std::string, inp_list&)':
> xml-tokenizer.cpp:30: error: conversion from 'size_t' to non-scalar type
> '__gnu_cxx::__normal_iterator<char*, std::basic_string<char,
> std::char_traits<char>, std::allocator<char> > >' requested
> xml-tokenizer.cpp:34: error: no match for 'operator=' in 'it = input.
> std::basic_string<_CharT, _Traits, _Alloc>::find_last_of [with _CharT =
> char, _Traits = std::char_traits<char>, _Alloc =
> std::allocator<char>](10, 4294967295u)'
>
> /usr/lib/gcc/i486-linux-gnu/4.1.2/../../../../include/c++/4.1.2/bits/stl_iterator.h:634:
> note: candidates are: __gnu_cxx::__normal_iterator<char*,
> std::basic_string<char, std::char_traits<char>, std::allocator<char> >
> >& __gnu_cxx::__normal_iterator<char*, std::basic_string<char,
> std::char_traits<char>, std::allocator<char> > >::operator=(const
> __gnu_cxx::__normal_iterator<char*, std::basic_string<char,
> std::char_traits<char>, std::allocator<char> > >&)
> make[2]: *** [xml-tokenizer.o] Error 1
>
> Is this due to library version issues?
> The previous version is good enough for my purposes now, but I thought
> I'd let you know.
>
> Thanks,
>
> Rebecca
>
>
>
> Bernd Kiefer wrote:
>
> >Hi,
> >
> >i just checked in two fixes, one of which should resolve ticket #2 by
> >Francis (could you check also it, please? thanks.) The other thing was
> >that file reading in XML mode was broken and now works again.
> >
> >Greetings,
> >
> >        Bernd
> >
> >
> >
>
>


-- 
--Eric Nichols
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.delph-in.net/archives/developers/attachments/20070215/72d2f5fa/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 18_xml-tokenizer_cpp.diff
Type: application/octet-stream
Size: 1027 bytes
Desc: not available
URL: <http://lists.delph-in.net/archives/developers/attachments/20070215/72d2f5fa/attachment.obj>