[pet] (Also style guide comments) Re: Poll to identify actively used functionality in PET

[Bernd Kiefer]

Hi Simon (and the rest of you)

On 06.07.2010 23:54, Simon Spero wrote:
> This is a stupid but related (in my brain) question:
>
> Is the cm branch going to become the trunk?  It feels like it's been the
> de facto trunk for a while.

Well, it's becoming main, which is the trunk in our SVN.

> Also, the style guide section on naming conventions seems to be
> self-inconsistent:
>
>     * Method and local Variable names adhere to the C standard: small
>       with underscores to separate multi-word names
>
> v.
>
>     * Capitalize only the first letter in acronyms
>           o loadXmlDocument()
>           o loadXMLDocument()

You're right. I prefer the old style, but have recently become
accustomed to the camelCase writing since i'm doing a lot in Java.

> (I personally prefer the initalLowercamelCase method/variable style as
> used in the loadXml example, but the examples aren't consistent with the
> '_' rule).
>
> Also, if there's refactoring in the air, might it be possible to get rid
> of some of the global variables like tGrammar *Grammar  (in cheap.cpp).
>   (hey, the names have to change to fit the naming conventions :-)

I've already removed lots of them, but not the more central ones.
In the beginning, they were made global because of efficiency reasons,
and one had to check how big the overhead would be of turning them into
non-global objects. And, yes, the names WILL change.

>
>
> Thanks
>
> Simon

Thanks to you for your comments!

Bernd

-- 
----------------------------------------------------------------------
Bernd Kiefer     DFKI GmbH,  Stuhlsatzenhausweg,  D-66123 Saarbruecken
kiefer at dfki.de   +49-681/85775-5301 (phone)   +49-681/85775-5338 (fax)
----------------------------------------------------------------------
Deutsches Forschungszentrum fuer Kuenstliche Intelligenz GmbH
Trippstadter Strasse 122, D-67663 Kaiserslautern, Germany
Geschaeftsfuehrung: Prof. Dr. Dr. h.c. mult. Wolfgang Wahlster (Vor-
                     sitzender), Dr. Walter Olthoff
Vorsitzender des Aufsichtsrats: Prof. Dr. h.c. Hans A. Aukes
Amtsgericht Kaiserslautern, HRB 2313